fix: dedup unstorage dependency and use subpath alias
#1164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pi0
changed the title
unstorage dependencyunstorage dependency and use subpath alias
|
Need to test more |
Codecov Report
@@ Coverage Diff @@
## main #1164 +/- ##
==========================================
- Coverage 76.58% 76.53% -0.05%
==========================================
Files 70 70
Lines 7182 7193 +11
Branches 714 714
==========================================
+ Hits 5500 5505 +5
- Misses 1681 1686 +5
- Partials 1 2 +1
|
|
Do you have an example reproduction? |
Unofrountaly not a stable one but this has been reported many times, especially within the Nuxt ecosystem. I am thinking to move it forward since this way of aliasing is better anyway by not pre-applying resolve conditions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Linked issue
β Type of change
π Description
Similar to other core deps (h3, radix3, defu), unstorage should be deduped otherwise there might be missing chunks in final output (this is not root cause but a common issue and this PR is basically a stable workaround to the issue)
π Checklist